Homec4science

Fix GitHub OAuth Registration for users without a name

Authored by epriestley <git@epriestley.com> on May 7 2011, 02:01.

Description

Fix GitHub OAuth Registration for users without a name

Summary:
Github allows you to have an account without a real name. The OAuth controller
actually handles this fine, mostly, except that it calls a bogus method. Also
there is some null vs empty string confusion.

Test Plan:
Deleted my name on Github and then registered for an account on Phabricator.

Reviewed By: tuomaspelkonen
Reviewers: jungejason, tuomaspelkonen, aran
CC: anjali, aran, tuomaspelkonen
Differential Revision: 247

Details

Committed
epriestley <git@epriestley.com>May 7 2011, 03:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4e70c434fdae: Fix Maniphest fatal when editing a task without changing anything
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH870f4bfe73d9: Fix GitHub OAuth Registration for users without a name (authored by epriestley <git@epriestley.com>).May 7 2011, 03:09