Homec4science

Make JOIN changes to CommitQuery only

Authored by epriestley <git@epriestley.com> on Apr 28 2014, 17:25.

Description

Make JOIN changes to CommitQuery only

Summary:
Fixes T4911. See D8879. This gives us the correct query in cases where there are no audits.

This doesn't try to do the GROUP BY stuff yet.

Test Plan:

  • Viewed a commit in Diffusion with no audits, got a commit detail page.
  • Viewed "All Commits" in web UI, saw commits without any audits included in the list.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4911

Differential Revision: https://secure.phabricator.com/D8882

Details

Committed
epriestley <git@epriestley.com>Apr 28 2014, 17:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0db6aad80d56: Audit - polish list view a bit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8716e734f039: Make JOIN changes to CommitQuery only (authored by epriestley <git@epriestley.com>).Apr 28 2014, 17:25