Homec4science

Selectively load columns for differential typeahead

Authored by Nicholas Harper <nharper@fb.com> on Oct 8 2011, 00:03.

Description

Selectively load columns for differential typeahead

Summary:
Change the differential typeahead to only load columns that it needs. To do
this, I also enabled partial objects for PhabricatorUser (and made necessary
changes to support this). I also changed the functionality of Lisk's loadColumns
to either accept columns as multiple string arguments or a single array of
strings.

Test Plan:
With tokenizer.ondemand set to false, checked that the typeahead loaded and I
can type multiple people's names. Set tokenizer.ondemand to true and tried
again. In both cases, the typeahead worked.

Reviewers: epriestley

Reviewed By: epriestley

CC: jungejason, aran, epriestley, nh

Differential Revision: 990

Details

Committed
Nicholas Harper <nharper@fb.com>Oct 8 2011, 00:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc3709c56fcbe: Add functionality to Lisk to only get some columns from the database
Branches
Unknown
Tags
Unknown

Event Timeline

Nicholas Harper <nharper@fb.com> committed rPH872ac17dbca5: Selectively load columns for differential typeahead (authored by Nicholas Harper <nharper@fb.com>).Oct 8 2011, 00:47