Homec4science

Display Reviewed By instead of first Reviewer in revisions overview

Authored by vrana <jakubv@fb.com> on Mar 4 2012, 11:44.

Description

Display Reviewed By instead of first Reviewer in revisions overview

Summary:
Displaying reviewer who was by coincidence listed first is quite confusing, especially for committed revisions.
This displays the one who really reviewed the revision if available.

This implementation is pretty bad from performance perspective - O(N) queries to retrieve all comments.
The page load still feels quite fast.

Test Plan: /differential/filter/revisions/

Reviewers: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1772

Details

Committed
vrana <jakubv@fb.com>Mar 5 2012, 19:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf2caa6888eea: Simplify Owners interfaces to Audit
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH87c60abbd02d: Display Reviewed By instead of first Reviewer in revisions overview (authored by vrana <jakubv@fb.com>).Mar 5 2012, 19:30