Conpherence - refactor display classes a bit
87d360bb1b4a
Actions

Authored by Bob Trahan <btrahan@phacility.com> on Apr 14 2015, 21:25.

Description

Conpherence - refactor display classes a bit

Summary:
D12409 made me realize this was a bit janky. PhabricatorTransactionView was only being used by Conpherence, so move and rename that class to ConpherenceTransactionView. Also, rename the existing ConpherenceTransactionView to ConpherenceTransactionRenderer, moving the actual view bits into the new ConpherenceTransactionView. Resulting code is a bit cleaner IMO.

Diff 1 of 2 (second diff has to be written. =D). Diff 2 will take care of the CSS and possibly clean things up further.

Test Plan: played around in conpherence full and conpherence column and things looked nice

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12410

Details

Committed

Bob Trahan <btrahan@phacility.com>

Apr 14 2015, 21:25

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHd90496a7192d: Conpherence - make timestamps in durable column link to full message in…

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH87d360bb1b4a: Conpherence - refactor display classes a bit (authored by Bob Trahan <btrahan@phacility.com>).Apr 14 2015, 21:25

Changes (7)

				Path
	M			src/__phutil_library_map__.php
	A			src/applications/conpherence/ConpherenceTransactionRenderer.php
	M			src/applications/conpherence/controller/ConpherenceUpdateController.php
	M			src/applications/conpherence/controller/ConpherenceViewController.php
	M			src/applications/conpherence/view/ConpherenceDurableColumnView.php
	M			src/applications/conpherence/view/ConpherenceTransactionView.php
	D			src/view/layout/PhabricatorTransactionView.php