Homec4science

Add /F123 shortcut

Authored by vrana <jakubv@fb.com> on May 3 2012, 23:46.

Description

Add /F123 shortcut

Summary:
I wanted to point someone on a file uploaded to Phabricator and the normal link is just too long.

I guess that this also improves security. Because pointing someone to the file directly reveals the secret key used in /data/ and it can be served without auth?

We already use {F123} so there will be no conflicts in future because we wouldn't want to reuse it for something else.

I promote the link on /file/ - it adds one redirect but I think it's worth it. I also considered making the link from the File ID column but there are already too many links (with some duplicity).

Test Plan:
/file/
/F123 (redirect)
/F9999999999 (404)

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2380

Details

Committed
vrana <jakubv@fb.com>May 4 2012, 08:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH416e4e7b672e: Allowing setting user status
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH87ff461470de: Add /F123 shortcut (authored by vrana <jakubv@fb.com>).May 4 2012, 08:51