Homec4science

When replying to a ghost comment, attach the reply to the same place

Authored by epriestley <git@epriestley.com> on Mar 11 2016, 01:05.

Description

When replying to a ghost comment, attach the reply to the same place

Summary:
Fixes T10562. I left this behavior sort of ambiguous in the original implementation because I didn't anticipate or stumble across this situation.

It's easy to fix: when you reply to a ghost, just put the reply in the exact same place as the ghost (even if it's a different diff), so they always move/ghost/port/thread together.

Test Plan:
See T10562 for reproduction steps and a "before" picture. Here's the after picture:

{F1168983}

The two comments at the bottom are pre-fix, and exhibit the bug. The comment at the top is post-fix, and appears adjacent to the original correctly.

Reviewers: chad

Reviewed By: chad

Subscribers: eadler

Maniphest Tasks: T10562

Differential Revision: https://secure.phabricator.com/D15458

Details

Committed
epriestley <git@epriestley.com>Mar 11 2016, 01:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7b8da9991429: Move DifferentialRevisionViewController to newPage()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8858b6cf8d17: When replying to a ghost comment, attach the reply to the same place (authored by epriestley <git@epriestley.com>).Mar 11 2016, 01:41