Homec4science

Allow DifferentialDiff to construct proper DifferentialChangeset objects from…

Authored by epriestley <git@epriestley.com> on Oct 23 2011, 23:33.

Description

Allow DifferentialDiff to construct proper DifferentialChangeset objects from diffs which add empty files

Summary:
See T507 and some others. We now parse empty git diffs correctly, but the logic
to build DifferentialDiffs out of them leaves the objects with 'null' for
$changesets, when it should be array().

Further layers later throw, believing we have not loaded the changesets, when we
actually have, there just aren't any.

Test Plan: Viewed rJX05d493e17fbbb29f29e4880be6834d1d7415374e in Diffusion,
which adds an empty README file. No exception thrown.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: nh

CC: aran, nh

Differential Revision: 1038

Details

Committed
epriestley <git@epriestley.com>Oct 25 2011, 08:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc84cfef16c5d: Actually apply monospacing to the monospaced font preference example
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH88be49fd5fa2: Allow DifferentialDiff to construct proper DifferentialChangeset objects from… (authored by epriestley <git@epriestley.com>).Oct 25 2011, 08:39