Homec4science

Fix "choose icon" on profile menu items

Authored by epriestley <git@epriestley.com> on Jan 21 2016, 19:02.

Description

Fix "choose icon" on profile menu items

Summary:
Ref T10054. This fix is a little rough but the "right" fix involves a ton of rewriting to AphrontSideNavFilterView and I don't want to open that can of worms up yet.

Specifically, the problem is:

  • we build the menu in order to populate the mobile/application menu;
  • as a side effect of building the menu (not rendering the menu), we initialize the menu collapse/expand behavior;
  • but we never actually render the menu, so the JX.$() call fails.

The right fix would be to initialize the behavior only when we render the menu, but then AphorntSideNavFilterView would need to know about profile menu behaviors. It probably should some day, but I think today is not that day.

Test Plan: Set icons on a link on a profile menu.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10054

Differential Revision: https://secure.phabricator.com/D15073

Details

Committed
epriestley <git@epriestley.com>Jan 21 2016, 19:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb51a859636ac: Allow diffusion.filecontentquery to load data for arbitrarily large files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH88e2929411be: Fix "choose icon" on profile menu items (authored by epriestley <git@epriestley.com>).Jan 21 2016, 19:05