Homec4science

Get rid of null characters

Authored by Nick Harper <nharper@fb.com> on Feb 22 2013, 19:07.

Description

Get rid of null characters

Summary:
We had some null bytes appearing in strings from unit test results, which
caused the PhutilRemarkupEngine to fail at properly generating html for it.
Specifically, the string would get cut off at the null byte, and the closing
</p> tag would never get added. The lack of this tag caused the dom for the
rest of the page to end up inside a hidden td in the unit test results table.

This is a horrible hack of a solution for this - it would be better to fix
PhutilRemarkupEngine (and in the future, strip out null bytes in input in
strings).

Test Plan: load a differential revision and see content after the unittest results

Reviewers: epriestley, vrana

Reviewed By: vrana

CC: aran, Korvin, rm

Differential Revision: https://secure.phabricator.com/D5065

Details

Committed
Nick Harper <nharper@fb.com>Feb 22 2013, 19:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc1f234759b04: Prefer MySQLi over MySQL
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH894cd13a41f7: Get rid of null characters (authored by Nick Harper <nharper@fb.com>).Feb 22 2013, 19:07