Homec4science

Make event-triggered actions more aware of application access

Authored by epriestley <git@epriestley.com> on Oct 22 2013, 02:00.

Description

Make event-triggered actions more aware of application access

Summary:
Fixes T3675.

  • Maniphest had a couple of old non-event listeners; move them to events.
  • Make most of the similar listeners a little more similar.
  • Add checks for access to the application.

Test Plan:

  • Viewed profile, project, task, revision.
  • Clicked all the actions.
  • Blocked access to various applications and verified the actions vanished.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3675

Differential Revision: https://secure.phabricator.com/D7365

Details

Committed
epriestley <git@epriestley.com>Oct 22 2013, 02:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd66972c9f295: Tie application event listeners to the applications they listen for
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8994a81b3538: Make event-triggered actions more aware of application access (authored by epriestley <git@epriestley.com>).Oct 22 2013, 02:00