Homec4science

Fix parsing of "Reviewed By" field

Authored by epriestley <git@epriestley.com> on Mar 13 2014, 02:11.

Description

Fix parsing of "Reviewed By" field

Summary: In the Message parser, we read this field and expect to get an array of PHIDs out of it. Currently, we get a string. Instead, get an array of PHIDs.

Test Plan: Wrote a message like "Fixes Tnnn" with "Reviewed by: duck", and saw no more parse error during message parsing.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Differential Revision: https://secure.phabricator.com/D8510

Details

Committed
epriestley <git@epriestley.com>Mar 13 2014, 02:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe068b04b5c95: Silence a warning about unknown fields in 'getcommitmessage'
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8a409aa40fe0: Fix parsing of "Reviewed By" field (authored by epriestley <git@epriestley.com>).Mar 13 2014, 02:11