Homec4science

Remove skins from Phame

Authored by epriestley <git@epriestley.com> on Dec 11 2015, 16:07.

Description

Remove skins from Phame

Summary:
Ref T9897. Purge a bunch of stuff:

  • Remove skins.
  • Remove all custom sites for skin resources.
  • Remove "framed", "notlive", "preview", separate "live" controllers (see below).
  • Merge "publish" and "unpublish" controllers into one.

New behavior:

  • Blogs and posts have three views:
    • "View": Internal view URI, which is a normal detail page.
    • "Internal Live": Internal view URI which is a little prettier.
    • "External Live": External view URI for an external domain.

Right now, the differences are pretty minor (basically, different crumbs/chrome). This mostly gives us room to put some milder flavor of skins back later (photography or more "presentation" elements, for example).

This removes 9 million lines of code so I probably missed a couple of things, but I think it's like 95% of the way there.

Test Plan:
Here are some examples of what the "view", "internal" and "external" views look like for blogs (posts are similar):

"View": Unchanged

{F1021634}

"Internal": No chrome or footer. Still write actions (edit, post commments). Has crumbs to get back into Phame.

{F1021635}

"External": No chrome or footer. No write actions. No Phabricator crumbs. No policy/status information.

{F1021638}

I figure we'll probably tweak these a bit to figure out what makes sense (like: maybe no actions on "internal, live"? and "external, live" probably needs a way to set a root "Company >" crumb?) but that they're reasonable-ish as a first cut?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9897

Differential Revision: https://secure.phabricator.com/D14740

Details

Committed
epriestley <git@epriestley.com>Dec 11 2015, 17:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc62e0a10f6b3: Clarify that ApplicationEditor supports editing itself
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8a906b0e18a7: Remove skins from Phame (authored by epriestley <git@epriestley.com>).Dec 11 2015, 17:14