Provide an "Add blocking reviewer..." Herald action
8aa8ef49dae1
Actions

Authored by epriestley <git@epriestley.com> on Oct 7 2013, 02:09.

Description

Provide an "Add blocking reviewer..." Herald action

Summary: Ref T1279. These reviewers don't actually create a logical block yet (that is, revisions still transition to "accepted" even in their presence), but this handles everything except that.

Test Plan: Added Herald rules and updated revisions; see screenshots.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7244

Details

Committed

epriestley <git@epriestley.com>

Oct 7 2013, 02:09

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH929ad86b5707: Allow accepting accepted revisions, and rejecting rejected revisions

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8aa8ef49dae1: Provide an "Add blocking reviewer..." Herald action (authored by epriestley <git@epriestley.com>).Oct 7 2013, 02:09

Changes (6)

				Path
	M			src/applications/differential/constants/DifferentialReviewerStatus.php
	M			src/applications/differential/editor/DifferentialRevisionEditor.php
	M			src/applications/differential/view/DifferentialReviewersView.php
	M			src/applications/herald/adapter/HeraldAdapter.php
	M			src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
	M			src/applications/herald/storage/HeraldRule.php