Homec4science

Differential - tighten up access of Differential data from other applications

Authored by Bob Trahan <btrahan@phacility.com> on Dec 19 2014, 23:54.

Description

Differential - tighten up access of Differential data from other applications

Summary: Fixes T6790. Turn the old method into "new" (old signature) and "newEphemeral". Deploy "newEphemeral" as many places as possible; basically places we are not in the Differential application *and* have no intentions of ever saving the diff. These callsites are also all places we are just trying to get some changesets at the end of the day.

Test Plan: set differential application policy to 'administrators only'. viewed a commit in diffusion and it worked without any errors! i'm just using my thinkin' noodle on the other code paths.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6790

Differential Revision: https://secure.phabricator.com/D11020

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 19 2014, 23:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfe0c1adf0eb7: Use darker text color in blockquote
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH8ac73b2bf351: Differential - tighten up access of Differential data from other applications (authored by Bob Trahan <btrahan@phacility.com>).Dec 19 2014, 23:54