Homec4science

Fix an issue where PhabricatorHandleList could fail to completely iterate

Authored by epriestley <git@epriestley.com> on May 9 2015, 22:23.

Description

Fix an issue where PhabricatorHandleList could fail to completely iterate

Fixes T8140. If a HandleList contained a null (because some caller sloppily added null as a handle), iteration (e.g., via iterator_to_array()) would abort prematurely.

In T8140, some of the project transactions add a null for an old file PHID when there's no old profile image.

Auditors: btrahan

Details

Committed
epriestley <git@epriestley.com>May 9 2015, 22:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7668d47e6da1: Fix conduit result tables on mobile views
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8b7a4670f8ea: Fix an issue where PhabricatorHandleList could fail to completely iterate (authored by epriestley <git@epriestley.com>).May 9 2015, 22:23