Homec4science

Turn off write guard when saving differential comment cache

Authored by Nicholas Harper <nharper@fb.com> on Aug 26 2011, 00:17.

Description

Turn off write guard when saving differential comment cache

Summary:
It is possible to view a comment that has no cache; when viewing such a comment
the request doesn't have a csrf token and there is no need for one, so we turn
off the write guard.

Test Plan:
loaded an old diff that had no cache, and the page loaded instead of throwing
an AphrontCSRFException.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: 858

Details

Committed
Nicholas Harper <nharper@fb.com>Aug 26 2011, 00:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH716eab82bb1c: Merge pull request #60 from moos3/master
Branches
Unknown
Tags
Unknown

Event Timeline

Nicholas Harper <nharper@fb.com> committed rPH8c0e5e1c58d1: Turn off write guard when saving differential comment cache (authored by Nicholas Harper <nharper@fb.com>).Aug 26 2011, 00:45