Homec4science

Partially fix a policy issue with ApplicationTransactions

Authored by epriestley <git@epriestley.com> on Aug 14 2013, 19:15.

Description

Partially fix a policy issue with ApplicationTransactions

Summary: Currently, we check that the user can view and edit their own transaction, which is always true. Instead, check that they can view the object. I'll fix this with a more tailored check against the EDIT capability that's per-transaction later.

Test Plan: Applying no transactions no longer fatals with undefined $xaction.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6754

Details

Committed
epriestley <git@epriestley.com>Aug 14 2013, 21:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf7b289e3a453: Make ReleephRequest implement PhabricatorCustomFieldInterface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8c3d1af627da: Partially fix a policy issue with ApplicationTransactions (authored by epriestley <git@epriestley.com>).Aug 14 2013, 21:34