Homec4science

Policy - convert repository worker to query revision with policy query

Authored by Bob Trahan <btrahan@phacility.com> on Feb 3 2015, 21:06.

Description

Policy - convert repository worker to query revision with policy query

Summary: Ref T7094. I guess theoretically someone could be making a commit and have just lost access to the revision and thus this could link this commit to that revision, but this all seems far fetched an weird? We also don't necessarily have the commit author's true identity since commit parsing can be a little funky to begin with. Anyhoo, functionally, this makes things no worse, but I am removing the TODO that would make us look at this in a fun way.

Test Plan: bin/repository reparse --owners rXvalidhash and it worked

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7094

Differential Revision: https://secure.phabricator.com/D11654

Details

Committed
Bob Trahan <btrahan@phacility.com>Feb 3 2015, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH026e3794831f: Policy - do proper policy queries when updating owners packages in commit…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH8c79b3eaede0: Policy - convert repository worker to query revision with policy query (authored by Bob Trahan <btrahan@phacility.com>).Feb 3 2015, 21:06