Homec4science

Don't require users be activated in order to establish Web sessions

Authored by epriestley <git@epriestley.com> on Jun 11 2015, 00:34.

Description

Don't require users be activated in order to establish Web sessions

Summary: Ref T8496. In D13123, the condition for establishing a web session was made too strict: we need to let non-activated users establish web sessions in order to see "you are a bad disabled person" or "your account needs approval" messages. The previous behavior let them in, the new behavior incorrectly locks them out.

Test Plan: Enabled login approvals and registered a new account with username/password auth.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: joshuaspence, epriestley

Maniphest Tasks: T8496

Differential Revision: https://secure.phabricator.com/D13239

Details

Committed
epriestley <git@epriestley.com>Jun 11 2015, 00:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5a00b5f6f62e: Garbage collect old notifications
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8d6209b70113: Don't require users be activated in order to establish Web sessions (authored by epriestley <git@epriestley.com>).Jun 11 2015, 00:34