Homec4science

Recover gracefully from Conduit failure when building "Tags" field in commit…

Authored by epriestley <git@epriestley.com> on Sep 22 2015, 22:03.

Description

Recover gracefully from Conduit failure when building "Tags" field in commit mail

Summary:
Ref T9458. This is basically the same as D13319, but the "Tags" field didn't get covered in that change.

Specifically, the issue is:

  • We try to generate mail to a disabled user (later, we'll drop it without delivering it, but that filtering doesn't happen yet).
  • The disabled user doesn't have permission to use Conduit (or any other Conduit-related problem occurs).
  • We fail here, then retry generating the mail again later.

Instead, just degrade to not building the field and showing what went wrong.

Test Plan:

  • Pushed some commits, saw mail generate.
  • Added a fake exception to the field, saw the mail generate with an error message.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9458

Differential Revision: https://secure.phabricator.com/D14142

Details

Committed
epriestley <git@epriestley.com>Sep 22 2015, 22:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH799d86dc657f: Show file UI box as collapsed in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8ded0927aa7f: Recover gracefully from Conduit failure when building "Tags" field in commit… (authored by epriestley <git@epriestley.com>).Sep 22 2015, 22:03