Homec4science

Add a Delete link to Differential inline comment previews

Authored by Alan Huang <alanh@fb.com> on Aug 2 2012, 21:24.

Description

Add a Delete link to Differential inline comment previews

Summary:
This lets you delete inlines from the preview at the bottom of
the page, instead of hunting for them through the diffs.

There is not yet a keyboard shortcut.

The mechanism for updating the inlines in the diffs is kind of a hack
and I'm sure I'm special-casing way too much, but at least it works.

Test Plan:
Load revision with many diffs. Create inlines all over the
place. Delete them all. Mwahaha.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1433, T1431

Differential Revision: https://secure.phabricator.com/D3131

Details

Committed
Alan Huang <alanh@fb.com>Aug 2 2012, 21:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce8bcf887d16: Render an edit link in Diffusion directory views
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPH8e5189b439a3: Add a Delete link to Differential inline comment previews (authored by Alan Huang <alanh@fb.com>).Aug 2 2012, 21:24