Homec4science

Clean up "ids" and "phids" handling in SearchEngines

Authored by epriestley <git@epriestley.com> on Dec 13 2015, 19:11.

Description

Clean up "ids" and "phids" handling in SearchEngines

Summary:
Ref T9964. I added several hacks to get these working. Clean them up and pull this into a proper extension.

The behavior in the web UI is:

  • they work in all applications; but
  • they only show up in the UI if a value is specified.

So if you visit /view/?ids=1,2 you get the field, but normally it's not present. We could refine this later. I'm going to add documentation about how to prefill these forms regardless, which should make this discoverable by reading the documentation.

There's one teensey weensey hack: in the API, I push these fields to the top of the table. That one feels OK, since it's purely a convenience/display adjustment.

Test Plan: Queried by IDs, reviewed docs.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9964

Differential Revision: https://secure.phabricator.com/D14769

Details

Committed
epriestley <git@epriestley.com>Dec 14 2015, 13:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfdd2d802d245: Clean up "*.search" API method documentation pages
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8ec413b97201: Clean up "ids" and "phids" handling in SearchEngines (authored by epriestley <git@epriestley.com>).Dec 14 2015, 13:24