Homec4science

Improve several Diffusion UI error states

Authored by epriestley <git@epriestley.com> on Sep 4 2011, 23:39.

Description

Improve several Diffusion UI error states

Summary:
Give users better errors and UI:

  • For subpath SVN repositories, default the path to the subdirectory, not to

"/". This makes the home screen useful and things generally less confusing.

  • For unparsed commits, show a more descriptive error message without the

"blah blah" silliness.

  • For paths outside of the subpath parse tree, short circuit into an

appropriate error message.

  • For foreign SVN stub commits (see D892), show an explicit message.

Test Plan: Looked at unparsed commits, subpath repositories, foreign stub
commits, and paths outside of the subpath parse tree. Received sensible error
messages.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: jungejason

CC: aran, jungejason

Differential Revision: 894

Details

Committed
epriestley <git@epriestley.com>Sep 5 2011, 01:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8b06d7d1c668: Merge branch 'master' of github.com:facebook/phabricator
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8f3b342287bc: Improve several Diffusion UI error states (authored by epriestley <git@epriestley.com>).Sep 5 2011, 01:18