Homec4science

Improve the `PhabricatorInfrastructureTestCase` unit tests

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 5 2014, 17:50.

Description

Improve the PhabricatorInfrastructureTestCase unit tests

Summary:
Improve the PhabricatorInfrastructureTestCase unit tests such that they will fail if any of the following conditions are satisfied:

  • A symbol referenced in the __phutil_library_map__.php file no longer exists.
  • A symbol exists in the library but is not referenced within the __phutil_library_map__.php file.
  • A symbol extends from a different parent symbol than that declared in the __phutil_library_map.php file.

Test Plan: See D9824.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9827

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 5 2014, 17:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3cb49d68d0f0: Point contributor documentation at Phacility CLAs, not Facebook CLAs
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPH8fa1708940c6: Improve the `PhabricatorInfrastructureTestCase` unit tests (authored by Joshua Spence <josh@joshuaspence.com>).Jul 5 2014, 17:50