Homec4science

When users submit a no-op edit in Phriction, don't update the document

Authored by epriestley <git@epriestley.com> on Jul 16 2012, 18:40.

Description

When users submit a no-op edit in Phriction, don't update the document

Summary:
See T1501. When users mash "save", stop them if they didn't change anything.

Also, don't default-fill the "edit notes" field with the previous notes. This is meant to be more like a commit message for your changes.

Test Plan: Edited a document with no changes, got a dialog. Edited a document with a title change only and a description change only, things worked. Edited a document with a previous "Edit notes", got a blank default fill.

Reviewers: alanh, btrahan, vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1501

Differential Revision: https://secure.phabricator.com/D2978

Details

Committed
epriestley <git@epriestley.com>Jul 16 2012, 18:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH23f2ffb81c5b: Add footer link to report a bug
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8fd97f435235: When users submit a no-op edit in Phriction, don't update the document (authored by epriestley <git@epriestley.com>).Jul 16 2012, 18:40