Homec4science

Don't show document types in search for uninstalled applications

Authored by epriestley <git@epriestley.com> on Apr 30 2014, 00:01.

Description

Don't show document types in search for uninstalled applications

Summary:
Fixes T4917. Currently, if a user doesn't have access to, e.g., Phriction, they still get a checkbox in the search results to search for Wiki Documents. Those results will be filtered anyway, so this is confusing at best.

Instead, bind PHID types to applications. This is a relatively tailored fix; some areas for potential future work:

  • Go through every PHID type and bind them all to applications. Vaguely nice to have, but doesn't get us anything for now.
  • If no searchable application is installed, we don't show you an error state. This isn't currently possible ("People" is always installed) but in the interest of generality we could throw an exception or something at least.
  • The elasticserach thing could probably constrain types to visible types, but we don't have a viewer there easily right now.

Test Plan: Uninstalled Phriction, saw the checkbox vanish.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4917

Differential Revision: https://secure.phabricator.com/D8904

Details

Committed
epriestley <git@epriestley.com>Apr 30 2014, 00:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1d5731b1ae3c: Restrict marking task duplicate to "merge duplicates" workflow
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8fe27800fcec: Don't show document types in search for uninstalled applications (authored by epriestley <git@epriestley.com>).Apr 30 2014, 00:01