Homec4science

Add DifferentialDiffQuery and change most callsites

Authored by epriestley <git@epriestley.com> on Jul 1 2013, 21:38.

Description

Add DifferentialDiffQuery and change most callsites

Summary:
Ref T603. This introduces a policy-aware DifferentialDiffQuery and converts most callsites.

I've left unusual callsites (mostly: hard to get the viewer, unusual query, queries related to active diffs) alone for now, so this isn't exhaustive but hits 60-80% of sites.

Test Plan: Created diff; created revision; viewed diffs and revisions; made additional conduit calls.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6338

Details

Committed
epriestley <git@epriestley.com>Jul 1 2013, 21:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH328aa383e460: Always provide a viewer when executing DifferentialRevisionQuery
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH90123dd7392f: Add DifferentialDiffQuery and change most callsites (authored by epriestley <git@epriestley.com>).Jul 1 2013, 21:38