Homec4science

Fix property shadowing on ActionListView after conversion to TagView

Authored by epriestley <git@epriestley.com> on Jan 18 2017, 20:29.

Description

Fix property shadowing on ActionListView after conversion to TagView

Summary:
See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an id property, and this new id property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan:

  • Viewed a task.
  • Made browser window narrow.
  • Clicked [= Actions] button.
  • After patch: saw a dropdown menu.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17223

Details

Committed
epriestley <git@epriestley.com>Jan 18 2017, 22:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH35f4514e3ff6: Fancier user menu
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH90258ed491d5: Fix property shadowing on ActionListView after conversion to TagView (authored by epriestley <git@epriestley.com>).Jan 18 2017, 22:14