Homec4science

Make old and new files when checking for changes by commit

Authored by vrana <jakubv@fb.com> on Jul 31 2012, 02:39.

Description

Make old and new files when checking for changes by commit

Summary:
We have some false positives on commit changes checker.
I'm not sure if the reason is a difference between git diff and svn diff or something else but making this more robust doesn't harm anything.

We couldn't make the files from the whole changeset because I want to ignore context bigger than $num_lines to reduce rebase noise.

Test Plan:
Ran the method on diff which had false positive previously.
Ran the method on a diff with real change.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3107

Details

Committed
vrana <jakubv@fb.com>Jul 31 2012, 02:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3c7944d297b2: Switch to new menubar
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH9092994e45c2: Make old and new files when checking for changes by commit (authored by vrana <jakubv@fb.com>).Jul 31 2012, 02:57