Homec4science

Fix logged-out Diffusion calls to Conduit

Authored by epriestley <git@epriestley.com> on Oct 22 2013, 22:47.

Description

Fix logged-out Diffusion calls to Conduit

Summary:
Conduit doesn't currently have an analog to "shouldAllowPublic", so the recent policy checks added here caught legitimate Conduit calls when viewing Diffusion as a logged-out user.

Add shouldAllowPublic() and set it for all the Diffusion queries.

(More calls probably need this, but we can add it when we hit them.)

Test Plan: Looked at Diffusion as a logged-out user with public access enabled.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7380

Details

Committed
epriestley <git@epriestley.com>Oct 22 2013, 22:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7dd31a16d973: Fix chatlog application query integration
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH90b83d7a92c5: Fix logged-out Diffusion calls to Conduit (authored by epriestley <git@epriestley.com>).Oct 22 2013, 22:47