Homec4science

Limit maximum size of Owners package queries

Authored by epriestley <git@epriestley.com> on Jul 9 2012, 19:51.

Description

Limit maximum size of Owners package queries

Summary:
Currently, a change may affect a very large number of paths. When we run the OwnersWorker on it, we'll execute a query which looks up packages for the paths. This may exceed "max_allowed_packet". Instead, break the list of paths into smaller chunks.

This is mostly to unblock r4nt / llvm, I'm going to add a more finessed approach to array_chunk() shortly.

Test Plan: Ran reparse.php --owners on a revision which affected packages, verified results are the same before and after the change. Set chunk size to 1, verified query results aggregated properly.

Reviewers: btrahan, jungejason, nh

Reviewed By: jungejason

CC: aran

Differential Revision: https://secure.phabricator.com/D2943

Details

Committed
epriestley <git@epriestley.com>Jul 9 2012, 19:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1089a48d4a66: Allow edges to be configured to prevent cycles
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH918ac5755c78: Limit maximum size of Owners package queries (authored by epriestley <git@epriestley.com>).Jul 9 2012, 19:51