Homec4science

Make some confusing/weird Calendar fields not configurable on custom EditEngine…

Authored by epriestley <git@epriestley.com> on Nov 16 2016, 15:55.

Description

Make some confusing/weird Calendar fields not configurable on custom EditEngine forms

Summary:
Ref T11816.

  • Host gets weird behavior around defaulting to the viewer.
  • Invitees get weird behavior around defaulting to the viewer.
  • "All Day" is just sort of weird since start / end date aren't customizable.
  • Recurring/Frequency are weird here and don't make much sense.

I can't immediately come up with reasons that any of these are particularly useful/valuable to default. More of them can be made editable after T10222 gets sorted out.

Test Plan: Edited edit engine custom forms for Calendar events, saw a more sensible list of customizable fields (e.g., policy stuff).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16878

Details

Committed
epriestley <git@epriestley.com>Nov 16 2016, 16:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH78bd6c1ce49f: Ensure that `PHUIInvisibleCharacterTestCase` is compatible with PHP 5.3
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH91ee6b78df3d: Make some confusing/weird Calendar fields not configurable on custom EditEngine… (authored by epriestley <git@epriestley.com>).Nov 16 2016, 16:49