Homec4science

Fix project hashtag bugs: duplicate tags, uppercase tags

Authored by epriestley <git@epriestley.com> on Dec 24 2015, 12:51.

Description

Fix project hashtag bugs: duplicate tags, uppercase tags

Summary:
Ref T8509. This fixes three issues:

  • Adding a slug like UPPERCASE would not give you a normalized slug. (Now: normalizes as uppercase.)
  • Adding a slug like UPPERCASE would allow you to give two different projects the different tags UPPERCASE and uppercase (and UpPeRcAsE, etc). (Now: second tag is rejected as a duplicate.)
  • Adding multiple identical or similar slugs would produce a duplicate key exception. (Now: ignores the duplicates.)

Test Plan:

  • Added test coverage.
  • Made tests pass.
  • Hit these cases in the UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8509

Differential Revision: https://secure.phabricator.com/D14870

Details

Committed
epriestley <git@epriestley.com>Dec 24 2015, 17:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdc5397b2db5d: Trivial fixes from D14467
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH92912a60720c: Fix project hashtag bugs: duplicate tags, uppercase tags (authored by epriestley <git@epriestley.com>).Dec 24 2015, 17:10