Homec4science

Don't apply space constraints to omnipotent-viewer queries

Authored by epriestley <git@epriestley.com> on Jul 3 2015, 19:59.

Description

Don't apply space constraints to omnipotent-viewer queries

Summary:
Fixes T8743. Fixes T8746. When running queries with the omnipotent viewer and no explicit space constraints, don't add implicit space constraints.

This prevents us from fataling when running older pre-space migrations and trying to load space-aware objects.

Test Plan: Manually ran migrations with --trace, verified no WHERE spacePHID = ....

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: eadler, epriestley

Maniphest Tasks: T8743, T8746

Differential Revision: https://secure.phabricator.com/D13542

Details

Committed
epriestley <git@epriestley.com>Jul 3 2015, 19:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa7cfc583531a: Explicitly document that lists can start at a number other than 1
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH92b73fed6b2c: Don't apply space constraints to omnipotent-viewer queries (authored by epriestley <git@epriestley.com>).Jul 3 2015, 19:59