Homec4science

Drive differential revision list with custom fields

Authored by epriestley <git@epriestley.com> on Feb 20 2012, 14:38.

Description

Drive differential revision list with custom fields

Summary:
Build the revision list table out of custom fields instead of hard-coding it, so
installs can add all sorts of zany things to it.

NOTE: You may need to implement sortFieldsForRevisionList() if you have a custom DifferentialFieldSelector, or some fields might show up out of order.

This implementation will preserve the expected behavior:

public function sortFieldsForRevisionList(array $fields) {
  $default = new DifferentialDefaultFieldSelector();
  return $default->sortFieldsForRevisionList($fields);
}

Test Plan:

  • Loaded differential revision list, identical to old list.
  • Profiled page to verify the cost increase isn't significant (it's quite

small).

Reviewers: jungejason, btrahan

Reviewed By: btrahan

CC: aran, btrahan, davidreuss, epriestley

Maniphest Tasks: T773, T729

Differential Revision: https://secure.phabricator.com/D1388

Details

Committed
epriestley <git@epriestley.com>Feb 20 2012, 14:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7a3f33b5c293: OAuth - Phabricator OAuth server and Phabricator client for new Phabricator…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH92f3ffd81185: Drive differential revision list with custom fields (authored by epriestley <git@epriestley.com>).Feb 20 2012, 14:38