Homec4science

Send graceful shutdown signals to daemons in Phabricator

Authored by epriestley <git@epriestley.com> on Aug 12 2014, 05:18.

Description

Send graceful shutdown signals to daemons in Phabricator

Summary:
Fixes T5855. Adds a --graceful N flag to phd stop and phd restart.

phd will send SIGINT, wait N seconds, SIGTERM, wait 15 seconds, and SIGKILL. By default, N is 15.

Test Plan:

  • Ran bin/phd debug ... and used ^C to interrupt daemons. Saw graceful shutdown behavior, and abrupt termination on multiple ^C.
  • Ran bin/phd start, bin/phd stop and bin/phd restart with --graceful set to various things, notably 0. Saw graceful shutdowns on the CLI and in the web UI. With 0, abrupt shutdowns.

Reviewers: btrahan, hach-que

Reviewed By: hach-que

Subscribers: epriestley

Maniphest Tasks: T5855

Differential Revision: https://secure.phabricator.com/D10228

Details

Committed
epriestley <git@epriestley.com>Aug 12 2014, 05:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaab0ed1c50df: Implement artifact release for Harbormaster
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9309723ac477: Send graceful shutdown signals to daemons in Phabricator (authored by epriestley <git@epriestley.com>).Aug 12 2014, 05:18