Homec4science

Fix start in fancy datepicker calendar

Authored by Dmitri Iouchtchenko <johnnyspoon@gmail.com> on Nov 5 2015, 16:07.

Description

Fix start in fancy datepicker calendar

Summary:
Fixes T9675.
Fixes the calculation for the difference between the first day of the month and the first day of the week. It was previously possible for this to be negative, which caused the subsequent loop to hang the browser.

Test Plan:

  • Set week to start on Sunday. Observed that the calendar still renders fine.
  • Set week to start on Monday. Observed that the browser no longer hangs on November 2015.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T9675

Differential Revision: https://secure.phabricator.com/D14409

Details

Committed
epriestley <git@epriestley.com>Nov 5 2015, 16:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6a035d977f22: Tweak grey tag color
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9366edf25589: Fix start in fancy datepicker calendar (authored by Dmitri Iouchtchenko <johnnyspoon@gmail.com>).Nov 5 2015, 16:07