Homec4science

Don't consider integer CustomFields as changed when the number doesn't change

Authored by epriestley <git@epriestley.com> on Feb 21 2014, 17:59.

Description

Don't consider integer CustomFields as changed when the number doesn't change

Summary: Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan:
{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Reviewers: btrahan, richardvanvelzen

Reviewed By: richardvanvelzen

CC: aran

Maniphest Tasks: T4466

Differential Revision: https://secure.phabricator.com/D8292

Details

Committed
epriestley <git@epriestley.com>Feb 21 2014, 17:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH67326bb47a0d: Fix phpmailer-lite bug
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9384c9e36b3d: Don't consider integer CustomFields as changed when the number doesn't change (authored by epriestley <git@epriestley.com>).Feb 21 2014, 17:59