Simplify and improve PhabricatorCustomField APIs
938b63aaa989
Actions

Authored by epriestley <git@epriestley.com> on Aug 14 2013, 18:40.

Description

Simplify and improve PhabricatorCustomField APIs

Summary:
Ref T1703. Ref T3718. The PhabricatorCustomFieldList seems like a pretty good idea. Move more code into it to make it harder to get wrong.

Also the sequencing on old/new values for these transactions was a bit off; fix that up.

Test Plan: Edited standard and custom profile fields.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1703, T3718

Committed

epriestley <git@epriestley.com>

Aug 14 2013, 21:34

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH938b63aaa989: Simplify and improve PhabricatorCustomField APIs (authored by epriestley <git@epriestley.com>).Aug 14 2013, 21:34

				Path
	M			src/applications/people/controller/PhabricatorPeopleProfileController.php
	M			src/applications/people/controller/PhabricatorPeopleProfileEditController.php
	M			src/applications/people/storage/PhabricatorUser.php
	M			src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	M			src/infrastructure/customfield/field/PhabricatorCustomField.php
	M			src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
	M			src/infrastructure/customfield/interface/PhabricatorCustomFieldInterface.php