Homec4science

Manage date control enabled state as part of DateControlValue

Authored by epriestley <git@epriestley.com> on May 4 2015, 19:08.

Description

Manage date control enabled state as part of DateControlValue

Summary: Ref T8024. Allow DateControlValue to manage enabled/disabled state, so we can eventually delete the copy of this logic in DateControl.

Test Plan:

  • Used Calendar ApplicationSearch queries to observe improved behaviors:
    • Error for invalid start date, if enabled.
    • Error for invalid end date, if enabled.
    • Error for invalid date range, if both enabled.
    • When submitting an invalid date (for example, with the time "Tea Time"), form retains invalid date verbatim instead of discarding information.
  • Created an event, using existing date controls to check that I didn't break anything.

Reviewers: chad, lpriestley, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8024

Differential Revision: https://secure.phabricator.com/D12673

Details

Committed
epriestley <git@epriestley.com>May 4 2015, 19:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPHba6b1376f261: Provide an "api" context to Multimeter for API events
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH948d69364aae: Manage date control enabled state as part of DateControlValue (authored by epriestley <git@epriestley.com>).May 4 2015, 19:08