Homec4science

Allow Herald rules to be disabled, instead of deleted

Authored by epriestley <git@epriestley.com> on Oct 7 2013, 02:10.

Description

Allow Herald rules to be disabled, instead of deleted

Summary:
Ref T603. Ref T1279. Further improves transaction and policy support for Herald.

  • Instead of deleting rules (which wipes out history and can't be undone) allow them to be disabled.
  • Track disables with transactions.
  • Gate disables with policy controls.
  • Show policy and status information in the headers.
  • Show transaction history on rule detail screens.
  • Remove the delete controller.
  • Support disabled queries in the ApplicationSearch.

Test Plan:

  • Enabled and disabled rules.
  • Searched for enabled/disabled rules.
  • Verified disabled rules don't activate.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279, T603

Differential Revision: https://secure.phabricator.com/D7247

Details

Committed
epriestley <git@epriestley.com>Oct 7 2013, 02:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc6add6ae7329: Make "reject" and "blocking reviewer" block acceptance in Differential
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH953ff197bf26: Allow Herald rules to be disabled, instead of deleted (authored by epriestley <git@epriestley.com>).Oct 7 2013, 02:10