Homec4science

Distinguish between invalid/broken handles and filtered handles

Authored by epriestley <git@epriestley.com> on Oct 17 2013, 19:49.

Description

Distinguish between invalid/broken handles and filtered handles

Summary:
Ref T603. Currently, we render handles the user doesn't have permission to see in a manner identical to handles that don't exist. This is confusing, and not required by policies (which restrict content, but permit knowledge that an object exists).

Instead, render them in different styles. Bad/invalid objects look like:

Unknown Object (Task)

Restricted objects look like:

  • Restricted Task

...where [o] is the padlock icon.

Test Plan:
{F71100}

{F71101}

It's possible this renders weird somewhere, but I wasn't immediately able to find any issues. Yell if you see something.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7334

Details

Committed
epriestley <git@epriestley.com>Oct 17 2013, 19:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcf8d7da292d2: Add some missing non-context translations
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH95c2b03fc8e5: Distinguish between invalid/broken handles and filtered handles (authored by epriestley <git@epriestley.com>).Oct 17 2013, 19:49