Homec4science

Improve unhandled exception dialogs

Authored by epriestley <git@epriestley.com> on Aug 17 2011, 23:29.

Description

Improve unhandled exception dialogs

Summary:
Make the unhandled exception dialogs slightly more useful:

  • Make them easier to read.
  • Link to files from Phabricator libraries.
  • Don't show traces by default.
  • Show traces in development mode.
  • Rename button from "Cancel" to "Close" and only show it for Ajax.

Test Plan: Rigged DirectoryHomeController to throw, loaded home page. Changed
stack trace setting in config. Clicked some files in the trace.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen, codeblock
CC: aran, epriestley
Differential Revision: 823

Details

Committed
epriestley <git@epriestley.com>Aug 18 2011, 01:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb291ad980726: Unguard thumbnail generation from CSRF.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH966778c2bdfb: Improve unhandled exception dialogs (authored by epriestley <git@epriestley.com>).Aug 18 2011, 01:23