Homec4science

Detect and raise setup warnings from within Phabricator

Authored by epriestley <git@epriestley.com> on Dec 30 2012, 15:37.

Description

Detect and raise setup warnings from within Phabricator

Summary:
This is basicaly a light version of D4286. The major problem with D4286 is that it's a huge leap and completely replaces the setup process in one step.

Instead, I want to do this:

  • Add the post-setup warnings (yellow bar with "6 unresolved warnings...").
  • Copy all setup checks into post-setup warnings (so every check has an old-style check and a new-style check).
  • Run that for a little bit and make sure it's stable.
  • Implement fatal post-setup checks (the red screen, vs the yellow bar).
  • Run that for a little bit.
  • Nuke setup mode and delete all the old checks.

This should give us a bunch of very gradual steps toward the brave new world of simpler setup.

Test Plan:

  • Faked APC setup failures, saw warnings raise.
  • Verified that this runs after restart (get + set).
  • Verified that this costs us only one cache hit after first-run (get only).

Reviewers: btrahan, codeblock, vrana, chad

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2228

Differential Revision: https://secure.phabricator.com/D4295

Details

Committed
epriestley <git@epriestley.com>Dec 30 2012, 15:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPHba489f9d85f3: Add a local configuration source and a non-environmental ENV config source
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH96839d35f49c: Detect and raise setup warnings from within Phabricator (authored by epriestley <git@epriestley.com>).Dec 30 2012, 15:37