Drive blame generation through `diffusion.blame`
9728c65e9358
Actions

Authored by epriestley <git@epriestley.com> on Jan 6 2016, 15:15.

Description

Drive blame generation through diffusion.blame

Summary:
Ref T2450. Ref T9319. This is still a bit messy, but not quite so bad as it was: instead of using a single call to get both blame information and file content, use diffusion.blame for blame information.

This will make optimizations to both blame and file content easier.

Test Plan: Viewed a bunch of blame (color on/off, blame on/off).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2450, T9319

Differential Revision: https://secure.phabricator.com/D14958

Details

Committed

epriestley <git@epriestley.com>

Jan 6 2016, 18:24

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHf561dc172d49: Implement a dedicated "diffusion.blame" API method

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9728c65e9358: Drive blame generation through `diffusion.blame` (authored by epriestley <git@epriestley.com>).Jan 6 2016, 18:24

Changes (11)

				Path
	M			src/__phutil_library_map__.php
	M			src/applications/diffusion/DiffusionLintSaveRunner.php
	M			src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php
	M			src/applications/diffusion/controller/DiffusionBrowseController.php
	D			src/applications/diffusion/query/__tests__
	D			src/applications/diffusion/query/__tests__/DiffusionGitFileContentQueryTestCase.php
	M			src/applications/diffusion/query/filecontent/DiffusionFileContentQuery.php
	M			src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php
	M			src/applications/diffusion/query/filecontent/DiffusionMercurialFileContentQuery.php
	M			src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php
	M			src/applications/repository/storage/PhabricatorRepositoryCommit.php