Homec4science

Add a "Needs Verification" state to Audit

Authored by epriestley <git@epriestley.com> on Jan 25 2017, 20:05.

Description

Add a "Needs Verification" state to Audit

Summary:
Fixes T2393. This allows authors to explicitly say "I think I fixed everything, please accept my commit now thank you".

Also improves behavior of "re-accept" and "re-reject" after new auditors you have authority over get added.

Test Plan:

  • Kicked a commit back and forth between an author and auditor by alternately using "Request Verification" and "Raise Concern".
  • Verified it showed up properly in bucketing for both users.
  • Accepted, added a project, accepted again (works now; didn't before).
  • Audited on behalf of projects / packages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2393

Differential Revision: https://secure.phabricator.com/D17252

Details

Committed
epriestley <git@epriestley.com>Jan 25 2017, 22:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPHca182c7f48ca: Clean up "Audit Authority" code, at least mostly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH97cac83e9b0c: Add a "Needs Verification" state to Audit (authored by epriestley <git@epriestley.com>).Jan 25 2017, 22:08