Homec4science

Strip restricted and incomplete handles from the "Mentions" tab on Maniphest…

Authored by epriestley <git@epriestley.com> on Nov 18 2016, 23:04.

Description

Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks

Summary:
Ref T8345. See T8345#201048 for discussion.

This rule (don't show mentions of or from restricted objects) is more consistent with how we render mentions in the timeline and I think generally a better behavior.

Test Plan:

  • Mentioned a task on a public task and a private task.
  • Privileged user (foreground) sees both.
  • Public user (background) sees only the public mention.

{F1929485}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8345

Differential Revision: https://secure.phabricator.com/D16900

Details

Committed
epriestley <git@epriestley.com>Nov 18 2016, 23:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8aeb7aa52587: Show file comments on file lightboxes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH97cd7a98b1e3: Strip restricted and incomplete handles from the "Mentions" tab on Maniphest… (authored by epriestley <git@epriestley.com>).Nov 18 2016, 23:08