Homec4science

Fix some minor issues with Maniphest file/attachment handling

Authored by epriestley <git@epriestley.com> on Oct 12 2011, 04:30.

Description

Fix some minor issues with Maniphest file/attachment handling

Summary:
@danielraffel is reporting an issue with file attachments which I can't
reproduce, but I did find a couple of minor things.

  • Elsewhere, we store array() as the value of these PHID dictionaries (the

idea being that we might store metadata there some day). While we may or may not
do this, we should at least be consistent.

  • When you edit a task, there's a file upload control but it doesn't actually

do anything. Just don't show it, there's no real reason to have it there.

Test Plan: Created a new task with attached files, verified they encoded as "[]"
instead of "true" in the database. Edited a task and didn't get a file control.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: danielraffel, aran

Differential Revision: 1003

Details

Committed
epriestley <git@epriestley.com>Oct 14 2011, 21:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9030f489cf52: Merge pull request #66 from mareksapota-fb/master
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH97f38b4e2733: Fix some minor issues with Maniphest file/attachment handling (authored by epriestley <git@epriestley.com>).Oct 14 2011, 21:49