Homec4science

Make "isInstalled()" respect beta apps

Authored by epriestley <git@epriestley.com> on Apr 6 2013, 18:25.

Description

Make "isInstalled()" respect beta apps

Summary:
Currently, isInstalled() and getAllInstalledApplications() are inconsistent:

  • isInstalled() returns true for beta apps, even if phabricator.show-beta-applications is false.
  • getAllInstalledApplications() omits beta apps if phabricator.show-beta-applications is false.

Making the beta config control installs (not just homepage visibility) makes far more sense as we roll out more thorough application integrations.

Make isInstalled() respect beta, and clean up some callsites.

D5602 builds on this.

Test Plan: Installed/uninstalled beta apps, verified Conpherence menu/panel and other application integrations dropped out of the UI.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D5603

Details

Committed
epriestley <git@epriestley.com>Apr 6 2013, 18:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa13864179540: Add a 7th column to AphrontMultiColumnView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH97ff7fe259d4: Make "isInstalled()" respect beta apps (authored by epriestley <git@epriestley.com>).Apr 6 2013, 18:25